Uh oh!
There was an error while loading. Please reload this page.
implement range/generate_series func - #8140
Conversation
Veeupup
commented
Nov 12, 2023
cc @jayzhan211@alamb this PR is ready for review! : ) |
2010YOUY01
commented
Nov 12, 2023
Thank you for this new function! Looks like these functions are available in DuckDB 👍🏼 https://duckdb.org/docs/sql/functions/nested.html#range-functions Here are some suggestions:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Veeupup
commented
Nov 12, 2023
thanks! I have made it clear in the test and doc. |
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you for the doc. I think the panic should be addressed. Everything else looks good to me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alamb
left a comment
There was a problem hiding this comment.
Thank you @Veeupup -- this looks great. I took the liberty of merging this branch up from main to resolve a conflict.
It would be great if you could add a doc comment explaining the arguments to gen_range , but I also think we could do that as a follow on PR if necessary.
Thanks again for the recent string of nice PRs 🙏
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: veeupup <code@tanweime.com>
Signed-off-by: veeupup <code@tanweime.com>
Signed-off-by: veeupup <code@tanweime.com>
alamb
commented
Nov 14, 2023
Thanks again @Veeupup and @jayzhan211 |
Which issue does this PR close?
Closes#8028 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
test in sqllogictests
Are there any user-facing changes?