Uh oh!
There was an error while loading. Please reload this page.
feat:implement calcite style 'levenshtein' string function - #8168
Conversation
alamb
left a comment
There was a problem hiding this comment.
Thank you for the contribution @Syleechan . I think we can avoid the new dependency but otherwise this looks great
Uh oh!
There was an error while loading. Please reload this page.
| sha2 = { version = "^0.10.1", optional = true } | ||
| unicode-segmentation = { version = "^1.7.1", optional = true } | ||
| uuid = { version = "^1.2", features = ["v4"] } | ||
| edit-distance = "2.1.0" |
There was a problem hiding this comment.
I think we can avoid this new dependency by either reusing our existing implementation (see below)
# Conflicts: # datafusion/proto/proto/datafusion.proto # datafusion/proto/src/generated/pbjson.rs # datafusion/proto/src/generated/prost.rs # datafusion/proto/src/logical_plan/from_proto.rs
Syleechan
commented
Nov 15, 2023
@alamb thanks, I have changed to use exsiting implementation. But the code checks maybe something wrong, I have used the checking command to run local all have passed. |
alamb
commented
Nov 15, 2023
I believe the failures are due to some logical conflicts since fixed in #8187 Updating to the latest main should work I think |
# Conflicts: # datafusion/proto/proto/datafusion.proto # datafusion/proto/src/generated/pbjson.rs # datafusion/proto/src/generated/prost.rs
Syleechan
commented
Nov 16, 2023
@alamb thanks, it works. And wait for your code review. |
alamb
left a comment
There was a problem hiding this comment.
looks good to me -- thank you @Syleechan
Which issue does this PR close?
Closes #.
Rationale for this change
https://calcite.apache.org/docs/reference.html#:~:text=LEVENSHTEIN(string1%2C%20string2,string1%20and%20string2
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?