Uh oh!
There was an error while loading. Please reload this page.
Minor fix ci break - #8186
Closed
haohuaijin wants to merge 1 commit into
Closed
Conversation
mustafasrepo
commented
Nov 15, 2023
Contributor
Thanks @haohuaijin for quick fix. |
tustvold
commented
Nov 15, 2023
Contributor
Thank you for this, I've bundled what I believe is the fix in #8187 |
mustafasrepo
approved these changes
Nov 15, 2023
Contributor
@mustafasrepo how would you like to proceed here, this PR fixes the conflicts from #8169 but not #8079 (merged after the CI for this ran). Shall we merge this first or just merge #8187? |
Contributor
I think merging just #8187 is better. Thanks @tustvold for this quick fix. As soon as ci passes, we can merge #8187. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?