Uh oh!
There was an error while loading. Please reload this page.
support LargeList for arrow_cast, support ScalarValue::LargeList - #8290
Merged
Conversation
7 tasks
LargeList for arrow_castLargeList for arrow_cast, support ScalarValue::LargeListWeijun-Hforce-pushed
the
scalar-largelist
branch
from
November 22, 2023 11:53
4f54551 to
991f3afComparealamb
reviewed
Nov 22, 2023
| } | ||
| } | ||
| (LargeList(arr1), LargeList(arr2)) => { | ||
| if arr1.data_type() == arr2.data_type() { |
Contributor
There was a problem hiding this comment.
@Weijun-H can you try (in a follow on PR) to use the arrow lt kernels diectly on the list (rather than calling it on each element)? I can't remember if the kernel knows how to handle things
| if list_arr1.len() != list_arr2.len() { | ||
| return None; | ||
| } | ||
| for i in 0..list_arr1.len() { |
Contributor
There was a problem hiding this comment.
I think the list lengths should always be 1, so I don't really understand why this is iterating (though I see it is just following the pattern of ListArray)
Contributor
There was a problem hiding this comment.
Maybe you can clean it up in a follow on PR (by asserting the list is length 1)
MemberAuthor
There was a problem hiding this comment.
I will work on this on the next PR
alamb
commented
Nov 22, 2023
Contributor
Thanks again @Weijun-H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
It is hard to test
LargeListin sqllogictest #8121, the convenient idea is to usearrow_cast()instead ofmake_arrayWhat changes are included in this PR?
LargeListforarrow_castScalarValue::LargeListScalarValue::new_large_listLargeListfor protobufAre these changes tested?
Are there any user-facing changes?