Uh oh!
There was an error while loading. Please reload this page.
Avoid concat for array_replace - #8337
Merged
Merged
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
marked this pull request as ready for review
November 28, 2023 13:47
8 tasks
alamb
approved these changes
Dec 1, 2023
alamb
left a comment
Contributor
There was a problem hiding this comment.
Very nice work @jayzhan211 👏
Dandandan
approved these changes
Dec 2, 2023
Dandandan
commented
Dec 2, 2023
Contributor
Thanks @jayzhan211 |
appletreeisyellow pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 14, 2023
* add benchmark Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fmt Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * address clippy Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * cleanup Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix comment Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on #8137
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Result in benchmark
n = 1e8
previous 2.0442s, this PR 1.6569s