fix: make ntile work in some corner cases

[haohuaijin]

Which issue does this PR close?

Closes#8284

Rationale for this change

fix#8284

What changes are included in this PR?

Add parameter type checking using Signature,
before

❯ select ntile('1') OVER(ORDER BY a) from t1;
Internal error: Cannot convert Utf8("1") to i64.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
❯ select ntile([]) OVER(ORDER BY a) from t1;
Internal error: Cannot convert List([NullArray(0)]) to i64.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker

after

❯ select ntile([]) OVER(ORDER BY a) from t1;
Error during planning: No function matches the given name and argument types 'NTILE(List(Field { name: "item", data_type: Null, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }))'. You might need to add explicit type casts.
Candidate functions:
NTILE(UInt64/UInt32/UInt16/UInt8/Int64/Int32/Int16/Int8)
❯ select ntile('1') OVER(ORDER BY a) from t1;
Error during planning: No function matches the given name and argument types 'NTILE(Utf8)'. You might need to add explicit type casts.
Candidate functions:
NTILE(UInt64/UInt32/UInt16/UInt8/Int64/Int32/Int16/Int8)

make ntile work properly, when parameter greater than table's row number

Are these changes tested?

yes, add more test

Are there any user-facing changes?

[haohuaijin]

cc @msirek@alamb , PTAL, I fix all incorrect results find in #8284, and add more tests.

[comphead]

Thanks @haohuaijin we prob can also test partition by nullorder by null cases

[alamb]

Perhaps @mustafasrepo or @ozankabak has time to review this code as they are more familiar with NTILE

[alamb]

I think this code looks good -- thank you @haohuaijin . If you can make the changes requested by @comphead I think this PR will be good to go

[haohuaijin]

@comphead I find partition by null and order by null will fail in all windows function(maybe, I'm not test all)

❯ CREATE TABLE t1 (a int) AS VALUES (1), (2), (3);
0 rows in set. Query took 0.018 seconds.
❯ select rank() over (partition by null) from t1;
thread 'tokio-runtime-worker' panicked at /home/hhj/datafusion/datafusion/physical-plan/src/repartition/mod.rs:208:79:
called `Result::unwrap()` on an `Err` value: InvalidArgumentError("must either specify a row count or at least one column")
Execution error: Expects PARTITION BY expression to be ordered
❯ select rank() over (order by null) from t1;
type_coercion
caused by
Internal error: Cannot run range queries on datatype: Null.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
❯ select sum(a) over (order by null) from t1;
type_coercion
caused by
Internal error: Cannot run range queries on datatype: Null.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
❯ select sum(a) over (partition by null) from t1;
Internal error: All partition by columns should have an ordering.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker

I file an issue #8386 to track this.

[mustafasrepo]

Thank @haohuaijin for this PR. It is rally nice. I added a minor comment (purely stylistic, you can ignore it if you wish). This PR is LGTM!.

[alamb]

Thank you @haohuaijin and @mustafasrepo