Uh oh!
There was an error while loading. Please reload this page.
flx clippy warnings - #8455
Merged
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
7 tasks
appletreeisyellow pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* change get zero to first() Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * wake clone to wake_by_ref Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * more first() Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * try_from() to from() Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Fix rust lints
What changes are included in this PR?
Two major warnings:
try_from().get(0)to.first()Are these changes tested?
Yes
Are there any user-facing changes?
No