Uh oh!
There was an error while loading. Please reload this page.
Minor: avoid a copy in Expr::unalias - #8588
Merged
Merged
Conversation
viirya
approved these changes
Dec 19, 2023
viirya
commented
Dec 19, 2023
Member
Thank you @alamb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While reviewing the excellent PR from #7942 I noticed we can avoid a (deep) copy in the
Expr::unaliascode without an API changeWhat changes are included in this PR?
Avoid a copy in
Expr::unaliasAre these changes tested?
exisiting tests
Are there any user-facing changes?
No