Uh oh!
There was an error while loading. Please reload this page.
Support for extract(x from time) / date_part from time types - #8693
Merged
Conversation
Jefffrey
commented
Dec 31, 2023
ContributorAuthor
Depends on apache/arrow-rs#5262 Will keep this in draft until arrow-rs support is merged and available to Datafusion (Also need to update docs) |
alamb
commented
Dec 31, 2023
Contributor
Release of arrow is tracked by apache/arrow-rs#5234 |
Jefffrey
commented
Jan 31, 2024
ContributorAuthor
Pending apache/arrow-rs#5337 which will come as part of arrow-rs v51.0.0 (next release) |
Jefffreyforce-pushed
the
extract_from_time
branch
from
March 19, 2024 21:20
99f2073 to
8e32ea8CompareJefffrey
marked this pull request as ready for review
March 19, 2024 21:20
Jefffrey
commented
Mar 19, 2024
Comment on lines
-155
to
-157
| /// | ||
| /// # Panics | ||
| /// If `array` is not a temporal type such as Timestamp or Date32 |
ContributorAuthor
There was a problem hiding this comment.
Realized my previous comment #9613 (comment) was incorrect about panics since it'll just return an error, so correcting here
| query R | ||
| SELECT date_part('microsecond', arrow_cast('23:32:50.123456789'::time, 'Time64(Nanosecond)')) | ||
| ---- | ||
| 50123456.789000005 |
ContributorAuthor
There was a problem hiding this comment.
Just floating point stuff
Not sure if want to look into it further or not
alamb
approved these changes
Mar 20, 2024
| } | ||
| Date32 => as_date32_array(array)?.unary(|x| x as f64 * SECONDS_IN_A_DAY), | ||
| Date64 => as_date64_array(array)?.unary(|x| x as f64 / 1_000_f64), | ||
| Time32(Second) => as_time32_second_array(array)?.unary(|x| x as f64), |
| ---- | ||
| 12123456780 | ||
| # test_date_part_time |
Contributor
There was a problem hiding this comment.
Is it also worth testing the EXTRACT (...) syntax too ?
like EXTRACT( hour from arrow_cast('23:32:50'::time, 'Time32(Second)')))?
| query R | ||
| SELECT date_part('microsecond', arrow_cast('23:32:50.123456789'::time, 'Time64(Nanosecond)')) | ||
| ---- | ||
| 50123456.789000005 |
extract(x from time)extract(x from time) / date_part from time typesalamb
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#8692
Rationale for this change
What changes are included in this PR?
Extend support for
extractanddate_parttoTime32andTime64types, for relevant precisions (hours, minutes, seconds, etc.)Are these changes tested?
Are there any user-facing changes?