Uh oh!
There was an error while loading. Please reload this page.
Implement trait based API for defining WindowUDF - #8719
Merged
Conversation
guojidan
marked this pull request as draft
January 2, 2024 08:10
guojidan
marked this pull request as ready for review
January 2, 2024 11:59
guojidan
commented
Jan 2, 2024
ContributorAuthor
cc @alamb |
alamb
commented
Jan 2, 2024
Contributor
Thank you @guojidan -- I plan to review this carefully later today |
9 tasks
alamb
approved these changes
Jan 2, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Wow @guojidan -- 👏 this is a really nice inital PR
I had one very small suggestion related to naming
I'll also file follow on tickets for similar cleanups as we did for ScalarFunctions (namely implement WindowUDF in terms of the trait)
But again, thank you for this PR
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
guojidan
commented
Jan 3, 2024
ContributorAuthor
@alamb Thank you for your affirmation, it gives me confidence to continue contributing this repository : ) I have modified the code according to your suggestion. |
alamb
approved these changes
Jan 3, 2024
alamb
commented
Jan 3, 2024
Contributor
Filed #8734 as a follow on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#8711 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?