Skip to content

Clean internal implementation of WindowUDF - #8746

Merged
alamb merged 2 commits into
apache:mainfrom
guojidan:udwf
Jan 5, 2024
Merged

Clean internal implementation of WindowUDF#8746
alamb merged 2 commits into
apache:mainfrom
guojidan:udwf

Conversation

@guojidan

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#8734 .

Rationale for this change

Clean internal implementation of WindowUDF to use WindowUDFImpl

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added logical-expr Logical plan and expressions core Core DataFusion crate labels Jan 4, 2024

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection @guojidan -- thank you very much for this PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratelogical-exprLogical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean internal implementation of WindowUDF to use WindowUDFImpl (rather than the function pointers)

2 participants

@guojidan@alamb