Uh oh!
There was an error while loading. Please reload this page.
Minor: Use standard tree walk in Projection Pushdown - #8787
Merged
Conversation
alambforce-pushed
the
alamb/simplify_expr_analysis
branch
from
January 8, 2024 14:46
1bd4684 to
dce26feComparehaohuaijin
approved these changes
Jan 9, 2024
haohuaijin
left a comment
Contributor
There was a problem hiding this comment.
Thank you @alamb for this great simplify 👍.
Dandandan
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #8774 / #8735
Rationale for this change
The core issue in #8735 was that one Expr type was forgotten. @haohuaijin restored the extra
Exprtype ❤️However, I think there is still some danger than a new Expr type would be added and forgotten to be added to this area. Thus I propose using the standard
TreeVisitorto do the recursionWhat changes are included in this PR?
Use
inspect_expr_preinstead of manual recursionAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No