Skip to content

Recursive CTEs: Stage 1 - add config flag - #8828

Merged
alamb merged 2 commits into
apache:mainfrom
matthewgapp:matt/feat/recursive-ctes/config-flag
Jan 17, 2024
Merged

Recursive CTEs: Stage 1 - add config flag #8828
alamb merged 2 commits into
apache:mainfrom
matthewgapp:matt/feat/recursive-ctes/config-flag

Conversation

@matthewgapp

@matthewgappmatthewgapp commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

This PR is the first step in a series of PRs to fully implement recursive CTEs in DF. This PR adds a config flag that will be used to gate further implementation of recursive CTE logical and execution plans

Which issue does this PR close?

Working toward closing #462

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the sql SQL Planner label Jan 11, 2024
@alamb

Copy link
Copy Markdown
Contributor

Thanks @matthewgapp -- what would you think about filing a ticket with the implementation plan described in #7581 (comment) (or maybe we can put it on #462 itself)?

@alamb

Copy link
Copy Markdown
Contributor

I think some tests need updating to get the CI run clean here

@matthewgapp

matthewgapp commented Jan 12, 2024

Copy link
Copy Markdown
ContributorAuthor

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

@matthewgapp

matthewgapp commented Jan 13, 2024

Copy link
Copy Markdown
ContributorAuthor

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

Spent most of my time today digging into the repro and solution to the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.

@github-actionsgithub-actionsBot added the sqllogictest SQL Logic Tests (.slt) label Jan 13, 2024
@matthewgapp
matthewgappforce-pushed the matt/feat/recursive-ctes/config-flag branch from 5c9fec5 to 91bc4a8CompareJanuary 14, 2024 00:05
@matthewgapp

Copy link
Copy Markdown
ContributorAuthor

I think some tests need updating to get the CI run clean here

Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.

Spent most of my time today digging into the repro and solution to the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.

Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.

@matthewgapp
matthewgappforce-pushed the matt/feat/recursive-ctes/config-flag branch from fa99090 to 91bc4a8CompareJanuary 15, 2024 18:32
@matthewgapp
matthewgapp marked this pull request as ready for review January 15, 2024 22:05
@matthewgapp

Copy link
Copy Markdown
ContributorAuthor

Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.

Think it's ready for review :)

Comment threadtesting
update docs from script
update slt test for doc change
@matthewgapp
matthewgappforce-pushed the matt/feat/recursive-ctes/config-flag branch from 91bc4a8 to 162e740CompareJanuary 16, 2024 17:31

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matthewgapp

@alamb
alamb merged commit 89d22b4 into apache:mainJan 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqlSQL PlannersqllogictestSQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewgapp@alamb