Skip to content

test: Port tests in csv_files.rs to sqllogictest - #8885

Merged
alamb merged 1 commit into
apache:mainfrom
simicd:test/csv-files-sqllogictest
Jan 16, 2024
Merged

test: Port tests in csv_files.rs to sqllogictest#8885
alamb merged 1 commit into
apache:mainfrom
simicd:test/csv-files-sqllogictest

Conversation

@simicd

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#8197

Rationale for this change

Migrate remaining SQL tests to sqllogictest

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the core Core DataFusion crate label Jan 16, 2024
use super::*;

#[tokio::test]
async fn csv_custom_quote() -> Result<()> {

@simicdsimicdJan 16, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

#[tokio::test]
async fn csv_custom_escape() -> Result<()> {

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding, thanks @simicd

@alamb
alamb merged commit 3f219bc into apache:mainJan 16, 2024
@simicd
simicd deleted the test/csv-files-sqllogictest branch January 16, 2024 21:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port tests in csv_files.rs to sqllogictest

3 participants

@simicd@comphead@alamb