Uh oh!
There was an error while loading. Please reload this page.
[MINOR]: Generate physical plan, instead of logical plan in the bench test - #9383
Merged
Merged
Conversation
alamb
approved these changes
Feb 28, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mustafasrepo -- makes sense to me
Uh oh!
There was an error while loading. Please reload this page.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While working on the PR, I recognized that
physical_plan_tpch_alltest indeed producesLogicalPlan. Hence its name is misleading, this may causes unintended consequences in the benchmarks. This PR fixes this so that name and the behavior is consistentWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?