Uh oh!
There was an error while loading. Please reload this page.
Improve documentation for ExecutionPlanProperties, use consistent field name - #9389
Conversation
5bdb95e to
fb3acf5Compare| /// | ||
| /// See also [`ExecutionPlan::maintains_input_order`] and [`Self::output_ordering`] | ||
| /// for related concepts. | ||
| fn equivalence_properties(&self) -> &EquivalenceProperties; |
There was a problem hiding this comment.
github rendered the diff strangely -- what I did was move the comments into the trait
| /// Stores output ordering of the [`ExecutionPlan`]. A `None` value represents | ||
| /// no ordering. | ||
| /// See [ExecutionPlanProperties::execution_mode] | ||
| pub execution_mode: ExecutionMode, |
There was a problem hiding this comment.
A drive by change was to rename this field to match the trait
ozankabak
left a comment
There was a problem hiding this comment.
LGTM, have one minor suggestion
| fn equivalence_properties(&self) -> &EquivalenceProperties; | ||
| } | ||
| impl ExecutionPlanProperties for Arc<dyn ExecutionPlan> { |
There was a problem hiding this comment.
| implExecutionPlanPropertiesforArc<dynExecutionPlan>{ | |
| implExecutionPlanPropertiesfordynExecutionPlan{ |
Maybe doing this will make the extension trait a bit more generally applicable?
There was a problem hiding this comment.
Added in 839d783
It turns out I had to also leave the
implExecutionPlanPropertiesforArc<dynExecutionPlan>{Otherwise the compiler didn't seem to be able to find the relevant methods without code changes (e.g. execution_plan.as_ref()....)
mustafasrepo
left a comment
There was a problem hiding this comment.
LGTM!. Thanks @alamb for this PR.
Draft until #9346 is merged
Which issue does this PR close?
Related to #9346
Rationale for this change
After #9346, some of the functions that were previously on ExecutionPlan were moved to an extension trait
But the docs don't show up in rustdoc
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?