Uh oh!
There was an error while loading. Please reload this page.
Add test for reading back file created with COPY ... OPTIONS (FORMAT..) options - #9753
Merged
Conversation
COPY ... OPTIONS (FORMAT..) optionsalamb
commented
Mar 29, 2024
ContributorAuthor
@metesynnada here is another small PR with tests that I wonder if you have time to review? |
metesynnada
approved these changes
Mar 30, 2024
metesynnada
left a comment
Contributor
There was a problem hiding this comment.
Should we phase out this usage at some point, or continue to support both options going forward?
alamb
commented
Apr 1, 2024
ContributorAuthor
That is a good question. I filed #9905 to discuss. I don't have a strong opinion |
tinfoil-knight added a commit
to tinfoil-knight/arrow-datafusion
that referenced
this pull request
Apr 7, 2024
…pache#9753)" This reverts commit b50f3aa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9744
Rationale for this change
The tests in #9744 show the syntax works, but doesn't verify that the format is actually used (rather than say, being ignored)
What changes are included in this PR?
Add a test to write to a file with a non standard extension and then read it back
Are these changes tested?
Are there any user-facing changes?
no, tests only