Skip to content

[feature-wip](array-type) Support loading data in vectorized format - #10065

Merged
HappenLee merged 2 commits into
apache:masterfrom
adonis0147:vec
Jun 15, 2022
Merged

[feature-wip](array-type) Support loading data in vectorized format#10065
HappenLee merged 2 commits into
apache:masterfrom
adonis0147:vec

Conversation

@adonis0147

@adonis0147adonis0147 commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#10064

Problem Summary:

Please refer to #10064

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: Yes
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

cambyzju
cambyzju reviewed Jun 10, 2022
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp Outdated
cambyzju
cambyzju reviewed Jun 10, 2022
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp Outdated
cambyzju
cambyzju reviewed Jun 10, 2022
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp Outdated
cambyzju
cambyzju reviewed Jun 10, 2022
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp
@eldenmoon

eldenmoon commented Jun 10, 2022

Copy link
Copy Markdown
Member

Sorry for my issue in this PR
I'm currently using Array, found that when I build BE with ASAN, using the column type like ARRAY<STRING>, after I insert with vectorized engine enabled, there will be a coredump which is heap-use-after-free, see issue #9934 for more details. I commented the clue I found in this PR #9466 (the last comment) , but I'm not quite sure how to solve it

@adonis0147

adonis0147 commented Jun 10, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi @eldenmoon , thanks for your feedback. I will investigate the issue you mentioned and try to solve it.

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/array-type Issues or PRs related to array type area/vectorization dev/backlog waiting to be merged in future dev branch labels Jun 10, 2022
@cambyzju

cambyzju commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

LGTM

HappenLee
HappenLee approved these changes Jun 14, 2022
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 14, 2022
@github-actions

github-actionsBot commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@HappenLee
HappenLee merged commit 983cdc7 into apache:masterJun 15, 2022
@adonis0147
adonis0147 deleted the vec branch June 15, 2022 08:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cambyzjucambyzjucambyzju left review comments
@HappenLeeHappenLeeHappenLee approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/array-typeIssues or PRs related to array typearea/vectorizationdev/backlogwaiting to be merged in future dev branchkind/fixCategorizes issue or PR as related to a bug.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][array-type] Failed to select array type data after enable storage vectorization.

5 participants

@adonis0147@eldenmoon@cambyzju@HappenLee@morningman