Skip to content

[refactor](schema change) spark dpp need not call convert rowset during load process - #11397

Merged
yiguolei merged 2 commits into
apache:masterfrom
yiguolei:remove_some_sc_code
Aug 2, 2022
Merged

[refactor](schema change) spark dpp need not call convert rowset during load process#11397
yiguolei merged 2 commits into
apache:masterfrom
yiguolei:remove_some_sc_code

Conversation

@yiguolei

@yiguoleiyiguolei commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Spark/MR dpp need not call convert rowset during load process. These code is never called.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 2, 2022
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 003335c into apache:masterAug 2, 2022

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yiguolei

Copy link
Copy Markdown
ContributorAuthor

part of #10136

@yiguolei
yiguolei deleted the remove_some_sc_code branch March 30, 2023 10:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@yiguolei@morningman@xy720@Doris-Extras