Skip to content

[improvement](planner) unset common fields to reduce plan thrift size - #12495

Merged
yiguolei merged 4 commits into
apache:masterfrom
morningman:unset_field
Sep 9, 2022
Merged

[improvement](planner) unset common fields to reduce plan thrift size#12495
yiguolei merged 4 commits into
apache:masterfrom
morningman:unset_field

Conversation

@morningman

@morningmanmorningman commented Sep 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

For query with 1656 union, the plan thrift size will be reduced from 400MB+ to 2MB.
This optimization is introduced from #4904, but lost after #9720

Disable ExprSubstitutionMap.verify when debug is disable.
So that the plan time of query with 1656 union will be reduced from 20s to 2s

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added the area/planner Issues or PRs related to the query planner label Sep 8, 2022
dataroaring
dataroaring approved these changes Sep 9, 2022
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 9, 2022
@github-actions

github-actionsBot commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit e84272e into apache:masterSep 9, 2022
@dataroaringdataroaring changed the title [improvment](planner) unset common fields to reduce plan thrift size[improvement](planner) unset common fields to reduce plan thrift sizeSep 9, 2022
yiguolei pushed a commit that referenced this pull request Sep 9, 2022
@morningman@Doris-Extras
[improvment](planner) unset common fields to reduce plan thrift size (#…
4461fd7
…12495)
1. For query with 1656 union, the plan thrift size will be reduced from 400MB+ to 2MB.
This optimization is introduced from #4904, but lost after #9720
2. Disable ExprSubstitutionMap.verify when debug is disable.
So that the plan time of query with 1656 union will be reduced from 20s to 2s
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
@morningman@Henry2SS
[improvment](planner) unset common fields to reduce plan thrift size (a…
6cac744
…pache#12495)
1. For query with 1656 union, the plan thrift size will be reduced from 400MB+ to 2MB.
This optimization is introduced from apache#4904, but lost after apache#9720
2. Disable ExprSubstitutionMap.verify when debug is disable.
So that the plan time of query with 1656 union will be reduced from 20s to 2s
@levy5307levy5307 mentioned this pull request Mar 12, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerdev/merge-1.1.2kind/improvementreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman@dataroaring@yiguolei