Uh oh!
There was an error while loading. Please reload this page.
[fix](csv-reader) fix new csv reader's performance issue - #15581
Merged
Conversation
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
TeamCity pipeline, clickbench performance test result: |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
morningman added a commit
that referenced
this pull request
Jan 8, 2023
Closed
luwei16 pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
…che#1342) commit 4075e3a Author: Mingyu Chen <morningman@163.com> Date: Wed Jan 4 18:25:08 2023 +0800 [fix](csv-reader) fix new csv reader's performance issue (apache#15581)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
#14604 fix the bug but introduce a performance issue.
This PR fix the performance issue when loading csv.
For clickbench load time, from 600s -> 470s
TODO:
Still slower than origin broker scan node, which is about 420s.
Will improve later.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...