Skip to content

[WIP](struct-type) support struct-type in vectorize engine - #15665

Merged
cambyzju merged 14 commits into
apache:struct-typefrom
xy720:struct-type-storage
Jan 12, 2023
Merged

[WIP](struct-type) support struct-type in vectorize engine#15665
cambyzju merged 14 commits into
apache:struct-typefrom
xy720:struct-type-storage

Conversation

@xy720

@xy720xy720 commented Jan 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close#14917

Problem summary

Work in progress.

This CL includes:
1、Change the be column meta to support struct type.(finish)
2、Add ColumnReader and ColumnWriter to support struct type. (finish)
3、Support creating table sql. (finish)

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/vectorization labels Jan 5, 2023
@xy720xy720 self-assigned this Jan 5, 2023
github-actions[bot]
github-actionsBot reviewed Jan 5, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/olap/types.cpp Outdated
Comment threadbe/src/olap/types.cpp Outdated
Comment threadbe/src/olap/types.h
Comment threadbe/src/olap/types.h
Comment threadbe/src/olap/types.h
Comment threadbe/src/olap/types.h
@apacheapache deleted a comment from github-actionsBotJan 5, 2023
@apacheapache deleted a comment from github-actionsBotJan 5, 2023
@apacheapache deleted a comment from github-actionsBotJan 5, 2023
@apacheapache deleted a comment from github-actionsBotJan 5, 2023
github-actions[bot]
github-actionsBot reviewed Jan 5, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/struct_value.h
Comment threadbe/src/runtime/struct_value.h Outdated
github-actions[bot]
github-actionsBot reviewed Jan 5, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/olap/types.cpp Outdated
github-actions[bot]
github-actionsBot reviewed Jan 5, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/olap/types.cpp Outdated
cambyzju
cambyzju reviewed Jan 10, 2023
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp
cambyzju
cambyzju reviewed Jan 10, 2023
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp Outdated
cambyzju
cambyzju reviewed Jan 10, 2023
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/column_writer.cpp Outdated
@github-actionsgithub-actionsBot added the area/sql/function Issues or PRs related to the SQL functions label Jan 12, 2023
github-actions[bot]
github-actionsBot reviewed Jan 12, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/olap/rowset/segment_v2/column_reader.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_factory.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_factory.cpp Outdated
Comment threadbe/src/vec/exprs/vstruct_literal.h Outdated
Comment threadbe/src/vec/exprs/vstruct_literal.h Outdated
cambyzju
cambyzju approved these changes Jan 12, 2023
View reviewed changes

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju
cambyzju merged commit 2578bad into apache:struct-typeJan 12, 2023
xy720 added a commit to xy720/doris that referenced this pull request Jan 13, 2023
@xy720xy720
[WIP](struct-type) support struct-type in vectorize engine (apache#15665
550e5b2
)
xy720 added a commit that referenced this pull request Feb 6, 2023
@xy720xy720
[WIP](struct-type) support struct-type in vectorize engine (#15665)
1146603
xy720 added a commit that referenced this pull request Feb 6, 2023
@xy720xy720
[WIP](struct-type) support struct-type in vectorize engine (#15665)
3d68b65
xy720 added a commit that referenced this pull request Feb 9, 2023
@xy720xy720
[WIP](struct-type) support struct-type in vectorize engine (#15665)
7012cf8
xy720 added a commit that referenced this pull request Feb 9, 2023
@xy720xy720
[WIP](struct-type) support struct-type in vectorize engine (#15665)
c662151
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@cambyzjucambyzjucambyzju approved these changes

Assignees

@xy720xy720

Labels

area/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorization

Projects

Doris support struct+map type
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xy720@cambyzju@carlvinhust2012