Skip to content

[feature](struct-type) adjust the vexpr for struct type - #15669

Merged
cambyzju merged 2 commits into
apache:struct-typefrom
carlvinhust2012:struct-type-vexpr
Jan 13, 2023
Merged

[feature](struct-type) adjust the vexpr for struct type#15669
cambyzju merged 2 commits into
apache:struct-typefrom
carlvinhust2012:struct-type-vexpr

Conversation

@carlvinhust2012

@carlvinhust2012carlvinhust2012 commented Jan 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  1. this pr is used to adjust the vexpr for struct type when we import data.
  2. load the json as below to the table which include the struct column.
    { "id" : 0, "s1" : { "name": "jack", "age": 20 } }]

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Jan 6, 2023
@carlvinhust2012carlvinhust2012 changed the title adjust the vexpr for struct type[feature](struct-type) adjust the vexpr for struct typeJan 6, 2023
github-actions[bot]
github-actionsBot reviewed Jan 6, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/columns/column_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
github-actions[bot]
github-actionsBot reviewed Jan 11, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/data_types/data_type_struct.h Outdated
Comment threadbe/src/vec/data_types/data_type_struct.h Outdated
@carlvinhust2012
carlvinhust2012force-pushed the struct-type-vexpr branch 4 times, most recently from 4b2d965 to 5a1d777CompareJanuary 12, 2023 07:58
github-actions[bot]
github-actionsBot reviewed Jan 12, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/columns/column_struct.cpp Outdated
Comment threadbe/src/vec/columns/column_struct.cpp Outdated
Comment threadbe/src/vec/columns/column_struct.cpp Outdated
Comment threadbe/src/vec/columns/column_struct.cpp Outdated
@carlvinhust2012
carlvinhust2012force-pushed the struct-type-vexpr branch 2 times, most recently from 7c5972f to 90a3056CompareJanuary 12, 2023 08:09
github-actions[bot]
github-actionsBot reviewed Jan 12, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
@carlvinhust2012
carlvinhust2012force-pushed the struct-type-vexpr branch 3 times, most recently from 568cb3e to c1f748bCompareJanuary 13, 2023 07:29
cambyzju
cambyzju reviewed Jan 13, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/Type.java Outdated
cambyzju
cambyzju reviewed Jan 13, 2023
View reviewed changes
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
cambyzju
cambyzju reviewed Jan 13, 2023
View reviewed changes
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_factory.cpp Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/Type.java Outdated
@carlvinhust2012
carlvinhust2012force-pushed the struct-type-vexpr branch 2 times, most recently from 38e8e62 to b51db18CompareJanuary 13, 2023 08:02
cambyzju
cambyzju reviewed Jan 13, 2023
View reviewed changes
Comment threadbe/src/vec/data_types/data_type_struct.cpp Outdated
@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actionsBot reviewed Jan 13, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/data_types/data_type_struct.cpp
Comment threadbe/src/vec/data_types/data_type_struct.cpp
@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@carlvinhust2012
carlvinhust2012force-pushed the struct-type-vexpr branch 2 times, most recently from 31c952d to c83fae7CompareJanuary 13, 2023 08:49
cambyzju
cambyzju approved these changes Jan 13, 2023
View reviewed changes

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju
cambyzju merged commit 7f4de92 into apache:struct-typeJan 13, 2023
@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

3 similar comments
@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720 pushed a commit to xy720/doris that referenced this pull request Jan 13, 2023
@carlvinhust2012xy720
[feature](struct-type) adjust the vexpr for struct type (apache#15669)
0d4da4f
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012xy720
[feature](struct-type) adjust the vexpr for struct type (#15669)
c10681b
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012xy720
[feature](struct-type) adjust the vexpr for struct type (#15669)
3818973
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012xy720
[feature](struct-type) adjust the vexpr for struct type (#15669)
fe34af5
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012xy720
[feature](struct-type) adjust the vexpr for struct type (#15669)
ca1bf0a
@xy720xy720 mentioned this pull request Feb 24, 2023
Closed
88 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@cambyzjucambyzjucambyzju approved these changes

Assignees

@carlvinhust2012carlvinhust2012

Labels

area/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorization

Projects

Doris support struct+map type
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlvinhust2012@cambyzju