[Feature](map) add map type to doris by amorynan · Pull Request #15966 · apache/doris

amorynan · 2023-01-16T07:51:34Z

Proposed changes

TO support doris complex type for map
Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

Does it affect the original behavior:
- Yes
- No
- I don't know
Has unit tests been added:
- Yes
- No
- No Need
Has document been added or modified:
- Yes
- No
- No Need
Does it need to update dependencies:
- Yes
- No
Are there any changes that cannot be rolled back:
- Yes (If Yes, please explain WHY)
- No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

… map

github-actions

clang-tidy made some suggestions

github-actions · 2023-01-16T08:01:40Z

+ if (!keys->equals(*rhs_map.keys))
+ return false;


warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
if (!keys->equals(*rhs_map.keys))
returnfalse;
if (!keys->equals(*rhs_map.keys)) {
returnfalse;
}

morningman · 2023-01-17T01:18:30Z

Please change the title and rebase the code

xiaokang

fe reviewed

xiaokang

be code reviewed

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 27. Check the log or trigger a new build to see more.

github-actions · 2023-02-02T04:12:17Z

+ create_data_type(col_desc.children[1], col_desc.contains_nulls[1]));
 break;
 }
+case INVALID_TYPE:


warning: 'case' statement not in switch statement [clang-diagnostic-error]
caseINVALID_TYPE: ^

github-actions · 2023-02-02T04:12:20Z

-for (int i = 0; i < _children.size(); ++i) {
-if (!_children[i]->is_constant()) {
-return false;
+ std::string VExpr::debug_string(const std::vector<VExprContext*>& ctxs) {


warning: function definition is not allowed here [clang-diagnostic-error]
std::string VExpr::debug_string(const std::vector<VExprContext*>& ctxs) { ^

github-actions · 2023-02-02T04:12:21Z


- return true;
-}
+ bool VExpr::is_constant() const {


warning: function definition is not allowed here [clang-diagnostic-error]
boolVExpr::is_constant() const { ^

github-actions · 2023-02-02T04:12:21Z

 }

- if (_constant_col != nullptr) {
+ Status VExpr::get_const_col(VExprContext * context, ColumnPtrWrapper * *output) {


warning: function definition is not allowed here [clang-diagnostic-error]
Status VExpr::get_const_col(VExprContext * context, ColumnPtrWrapper * *output) { ^

xy720 · 2023-02-02T07:23:35Z

+return Status::OK();
+}

-Status VExpr::create_tree_from_thrift(doris::ObjectPool* pool,


Why modify here?

when I use clang-format.sh , it make these change...

This reverts commit 817e0ab.

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions · 2023-02-02T09:48:20Z

clang-tidy review says "All clean, LGTM! 👍"

xy720

LGTM

github-actions · 2023-02-03T03:58:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-02-03T03:59:01Z

PR approved by anyone and no changes requested.

Add complex type map to doris on vectorized engine

amorynan added 2 commits January 4, 2023 19:04

first commit
6e079af

update reader & writer for column map and add element_at function for…
1c10e94
… map

github-actionsBot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Jan 16, 2023

github-actionsBot reviewed Jan 16, 2023
View reviewed changes

amorynan changed the base branch from master to struct-typeJanuary 16, 2023 10:05

carlvinhust2012 reviewed Jan 17, 2023
View reviewed changes

Comment threadbe/src/olap/field.h Outdated

xy720 assigned amorynan Jan 17, 2023

amorynan changed the title ~~feature-map~~[Feature](map)support complex struct for dorisJan 17, 2023

xiaokang reviewed Jan 17, 2023
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_map.cpp Outdated

xiaokang reviewed Jan 17, 2023
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_map.cpp

xiaokang reviewed Jan 17, 2023
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_map.cpp Outdated

xiaokang reviewed Jan 17, 2023
View reviewed changes

xy720 reviewed Jan 17, 2023
View reviewed changes

Comment threadbe/src/olap/rowset/segment_v2/column_writer.cpp Outdated
Comment threadbe/src/vec/columns/column_map.h
Comment threadbe/src/vec/columns/column_map.h
Comment threadbe/src/vec/core/field.h

xy720 reviewed Jan 18, 2023
View reviewed changes

update some for map
d3d2b16

amorynan requested review from xiaokang and xy720 and removed request for xiaokang January 29, 2023 07:38

github-actionsBot reviewed Jan 29, 2023
View reviewed changes

Merge branch 'struct-type' into feature-map
ac9c7e6

github-actionsBot reviewed Jan 29, 2023
View reviewed changes

xy720 reviewed Feb 1, 2023
View reviewed changes

clean column writer for map and olap data convetor
615aa07

amorynan requested review from xiaokang and removed request for xiaokang February 1, 2023 10:48

amorynan requested a review from xiaokang February 1, 2023 10:49

amorynan added 2 commits February 2, 2023 08:09

update from_string and code format
ed5225e

use check clang format
817e0ab

github-actionsBot reviewed Feb 2, 2023
View reviewed changes

xy720 reviewed Feb 2, 2023
View reviewed changes

amorynan added 2 commits February 2, 2023 15:51

Revert " use check clang format"
50be1da
This reverts commit 817e0ab.

format data_type_factory
7a06b3a

github-actionsBot reviewed Feb 2, 2023
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_factory.cpp
Comment threadbe/src/vec/data_types/data_type_factory.cpp

format data_type_factory
51ea6e2

github-actionsBot reviewed Feb 2, 2023
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_factory.cpp
Comment threadbe/src/vec/data_types/data_type_factory.cpp

amorynan changed the title ~~[Feature](map)support complex struct for doris~~[Feature](map) add map type to dorisFeb 2, 2023

update
0c50055

update format
94e9bd5

amorynan requested review from xy720 and removed request for xiaokang and xy720 February 2, 2023 14:50

xy720 approved these changes Feb 3, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 3, 2023

github-actionsBot added the reviewed label Feb 3, 2023

amorynan requested a review from xiaokang February 3, 2023 04:04

xy720 merged commit af9234b into apache:struct-typeFeb 3, 2023

xy720 pushed a commit that referenced this pull request Feb 6, 2023
[Feature](map) add map type to doris (#15966)
ebfd14c
Add complex type map to doris on vectorized engine

xy720 pushed a commit that referenced this pull request Feb 9, 2023
[Feature](map) add map type to doris (#15966)
5b2becf
Add complex type map to doris on vectorized engine

xy720 pushed a commit that referenced this pull request Feb 9, 2023
[Feature](map) add map type to doris (#15966)
3d4d1a1
Add complex type map to doris on vectorized engine

-if (!keys->equals(*rhs_map.keys))
-returnfalse;
+if (!keys->equals(*rhs_map.keys)) {
+returnfalse;
+}

Uh oh!

Conversation

amorynan commented Jan 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Problem summary

Checklist(Required)

Further comments

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBotJan 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

morningman commented Jan 17, 2023

Uh oh!

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amorynan commented Jan 16, 2023•
edited
Loading