Skip to content

[fix](struct-type) support to remove double or single quote - #15977

Merged
cambyzju merged 1 commit into
apache:struct-typefrom
carlvinhust2012:struct-type
Jan 16, 2023
Merged

[fix](struct-type) support to remove double or single quote#15977
cambyzju merged 1 commit into
apache:struct-typefrom
carlvinhust2012:struct-type

Conversation

@carlvinhust2012

@carlvinhust2012carlvinhust2012 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

  1. this pr is used to support to remove double or single quote.
    Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. labels Jan 16, 2023
@carlvinhust2012
carlvinhust2012 changed the base branch from master to struct-typeJanuary 16, 2023 09:53
@github-actions

github-actionsBot commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

cambyzju
cambyzju approved these changes Jan 16, 2023
View reviewed changes

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 16, 2023
@github-actions

github-actionsBot commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@cambyzju
cambyzju merged commit b5a048b into apache:struct-typeJan 16, 2023
@xy720xy720 assigned xy720 and carlvinhust2012 and unassigned xy720Jan 17, 2023
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012xy720
[fix](struct-type) support to remove double or single quote (#15977)
1f360b6
xy720 pushed a commit that referenced this pull request Feb 6, 2023
@carlvinhust2012xy720
[fix](struct-type) support to remove double or single quote (#15977)
747cc04
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012xy720
[fix](struct-type) support to remove double or single quote (#15977)
20d377b
xy720 pushed a commit that referenced this pull request Feb 9, 2023
@carlvinhust2012xy720
[fix](struct-type) support to remove double or single quote (#15977)
0f9be0e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cambyzjucambyzjucambyzju approved these changes

Assignees

@carlvinhust2012carlvinhust2012

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorizationkind/docsCategorizes issue or PR as related to documentation.reviewed

Projects

Doris support struct+map type
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlvinhust2012@cambyzju@xy720