Uh oh!
There was an error while loading. Please reload this page.
[refactor](reader) refactor broker_file_reader to get _client in the constructor - #16021
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
a747c74 to
7fb6323Compareclang-tidy review says "All clean, LGTM! 👍" |
7fb6323 to
ab70320Compareclang-tidy review says "All clean, LGTM! 👍" |
TeamCity pipeline, clickbench performance test result: |
ab70320 to
0e563e5Compareclang-tidy review says "All clean, LGTM! 👍" |
luozenglin
commented
Jan 18, 2023
@HappenLee cc |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
The connection held in broker reader will be null(the internal client is set to nullptr) after reopening the connection to the broker failed. |
Proposed changes
Issue Number: close #xxx
related pr: #15874
Problem summary
In #15874, @HappenLee's comment is valid. There is no problem getting the client in the constructor and the logic is much clearer.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...