Uh oh!
There was an error while loading. Please reload this page.
[enhancement](load) avoid schema copy to reduce cpu usage - #16034
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TeamCity pipeline, clickbench performance test result: |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
| wrequest.slots = index_slots; | ||
| wrequest.is_high_priority = _is_high_priority; | ||
| wrequest.ptable_schema_param = request.schema(); | ||
| wrequest.table_schema_param = _schema; |
There was a problem hiding this comment.
_schema is inited from request.schema(), and it's life cycle is longer than delta writers, so we can use _schema directly to avoid copying the schema twice(the first time is here, the second time is in the ctor of DeltaWriter)
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
Issue Number: close #xxx
Problem summary
some user reports that the cpu usage is quite high when data loading.

The flame graph shows that copy of the schema cost lots of cpu resources.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...