Skip to content

[enhancement](load) avoid schema copy to reduce cpu usage - #16034

Merged
dataroaring merged 4 commits into
apache:masterfrom
zhannngchen:fix-cpu-high
Jan 28, 2023
Merged

[enhancement](load) avoid schema copy to reduce cpu usage#16034
dataroaring merged 4 commits into
apache:masterfrom
zhannngchen:fix-cpu-high

Conversation

@zhannngchen

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

some user reports that the cpu usage is quite high when data loading.
The flame graph shows that copy of the schema cost lots of cpu resources.
image

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/olap/delta_writer.cpp Outdated
Comment threadbe/src/olap/tablet_schema.h
@hello-stephen

hello-stephen commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.76 seconds
load time: 509 seconds
storage size: 17123237211 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119030741_clickbench_pr_83804.html

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

wrequest.slots = index_slots;
wrequest.is_high_priority = _is_high_priority;
wrequest.ptable_schema_param = request.schema();
wrequest.table_schema_param = _schema;

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_schema is inited from request.schema(), and it's life cycle is longer than delta writers, so we can use _schema directly to avoid copying the schema twice(the first time is here, the second time is in the ctor of DeltaWriter)

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 28, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/1.2.2-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zhannngchen@hello-stephen@dataroaring@morningman