Skip to content

[fix](struct-type) fix insert null and explain for struct type - #16054

Merged
xy720 merged 3 commits into
apache:struct-typefrom
cambyzju:struct-0118
Jan 18, 2023
Merged

[fix](struct-type) fix insert null and explain for struct type#16054
xy720 merged 3 commits into
apache:struct-typefrom
cambyzju:struct-0118

Conversation

@cambyzju

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

  1. support insert null for struct type;
  2. fix explain const exprs for strut type got wrong result;
> explain insert into example3 values(20,{12345678,12345679}),(21,{12345678,12345679});
+------------------------------------------+
| Explain String |
+------------------------------------------+
| PLAN FRAGMENT 0 |
| OUTPUT EXPRS: |
| <slot 2> 20 |
| <slot 3> STRUCT(12345678, 12345679) |
| PARTITION: UNPARTITIONED |
| |
| OLAP TABLE SINK |
| TUPLE ID: 0 |
| RANDOM |
| |
| 0:VUNION |
| constant exprs: |
| 20 | STRUCT(12345678, 12345679) |
| 21 | STRUCT(12345678, 12345679) |
+------------------------------------------+

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/vectorization labels Jan 18, 2023
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 18, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xy720
xy720 merged commit 5175a45 into apache:struct-typeJan 18, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720 pushed a commit that referenced this pull request Feb 6, 2023
1、support insert null for struct type;
2、fix explain const exprs for strut type got wrong result;
Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
xy720 pushed a commit that referenced this pull request Feb 6, 2023
1、support insert null for struct type;
2、fix explain const exprs for strut type got wrong result;
Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
xy720 pushed a commit that referenced this pull request Feb 9, 2023
1、support insert null for struct type;
2、fix explain const exprs for strut type got wrong result;
Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
xy720 pushed a commit that referenced this pull request Feb 9, 2023
1、support insert null for struct type;
2、fix explain const exprs for strut type got wrong result;
Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
@xy720xy720 mentioned this pull request Feb 24, 2023
88 tasks
@cambyzju
cambyzju deleted the struct-0118 branch March 12, 2024 02:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerarea/vectorizationreviewed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@cambyzju@xy720