Uh oh!
There was an error while loading. Please reload this page.
[Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision - #16190
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity pipeline, clickbench performance test result: |
| #pragma once | ||
| #include <fast_float/fast_float.h> |
There was a problem hiding this comment.
warning: 'fast_float/fast_float.h' file not found [clang-diagnostic-error]
#include<fast_float/fast_float.h>
^…o avoid lose precision
clang-tidy review says "All clean, LGTM! 👍" |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…o avoid lose precision (#16190)
…o avoid lose precision (apache#16190)
Proposed changes
load data.csv
select * from table
after the fix
select * from table
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...