Skip to content

[fix](complex_type) fix clone_type_info function return default scalar type - #16400

Merged
xy720 merged 3 commits into
apache:struct-typefrom
amorynan:fix-typeInfo
Feb 6, 2023
Merged

[fix](complex_type) fix clone_type_info function return default scalar type#16400
xy720 merged 3 commits into
apache:struct-typefrom
amorynan:fix-typeInfo

Conversation

@amorynan

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@carlvinhust2012

Copy link
Copy Markdown
Contributor

LGTM

Comment threadbe/src/olap/types.cpp Outdated
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@xy720
xy720 merged commit cd5a6b0 into apache:struct-typeFeb 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/vectorizationreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@amorynan@carlvinhust2012@cambyzju@xy720