Skip to content

[Fix](load) Fix memory leak for stream load 2pc - #16430

Merged
yiguolei merged 1 commit into
apache:masterfrom
weizuo93:fix-stream-load-2pc-mem-leak
Feb 6, 2023
Merged

[Fix](load) Fix memory leak for stream load 2pc#16430
yiguolei merged 1 commit into
apache:masterfrom
weizuo93:fix-stream-load-2pc-mem-leak

Conversation

@weizuo93

@weizuo93weizuo93 commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Fix memory leak for stream load 2pc.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

@weizuo93weizuo93 changed the title [Fix] Fix memory leak for stream load 2pc[Fix](load) Fix memory leak for stream load 2pcFeb 6, 2023
@github-actions

github-actionsBot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.29 seconds
load time: 470 seconds
storage size: 17170880165 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230206044346_clickbench_pr_90646.html

yiguolei
yiguolei approved these changes Feb 6, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit da27039 into apache:masterFeb 6, 2023
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2023
@github-actions

github-actionsBot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

morningman pushed a commit that referenced this pull request Feb 6, 2023
@weizuo93weizuo@morningman
[Fix](load) Fix memory leak for stream load 2pc#16430
ae5dfa9
StreamLoadContext is not deleted correctly.
Co-authored-by: weizuo <weizuo@xiaomi.com>
@morningmanmorningman mentioned this pull request Feb 6, 2023
Closed
weizuo93 added a commit to weizuo93/incubator-doris that referenced this pull request Feb 23, 2023
@weizuo93weizuo
[Fix](load) Fix memory leak for stream load 2pcapache#16430
bd31709
StreamLoadContext is not deleted correctly.
Co-authored-by: weizuo <weizuo@xiaomi.com>
yiguolei pushed a commit that referenced this pull request Feb 27, 2023
@weizuo93weizuo
[Fix](load) Fix memory leak for stream load 2pc#16430(#17085)
a05abfa
StreamLoadContext is not deleted correctly.
Co-authored-by: weizuo <weizuo@xiaomi.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/1.1.6dev/1.2.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weizuo93@hello-stephen@yiguolei@morningman