Skip to content

[improvement](vresultsink) BufferControlBlock may block all fragment threads - #16559

Closed
yinzhijian wants to merge 1 commit into
apache:masterfrom
yinzhijian:improvement.wait
Closed

[improvement](vresultsink) BufferControlBlock may block all fragment threads#16559
yinzhijian wants to merge 1 commit into
apache:masterfrom
yinzhijian:improvement.wait

Conversation

@yinzhijian

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#16203

Problem summary

same as #16231
but resolve the bug in a more elegant manner

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/result_buffer_mgr.h Outdated
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@chenlinzhongchenlinzhong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 9, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.51 seconds
stream load tsv: 477 seconds loaded 74807831229 Bytes, about 149 MB/s
stream load json: 35 seconds loaded 2358488459 Bytes, about 64 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230209121948_clickbench_pr_93046.html

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, need modification

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Feb 10, 2023
@github-actions

Copy link
Copy Markdown
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] BufferControlBlock may block all fragment handle threads leads to be out of work

4 participants

@yinzhijian@hello-stephen@yiguolei@chenlinzhong