Skip to content

[Feature](map-type) Support stream load and fix some bugs for map type - #16776

Merged
xy720 merged 9 commits into
apache:masterfrom
amorynan:feature-supportMapStreamLoad
Feb 19, 2023
Merged

[Feature](map-type) Support stream load and fix some bugs for map type#16776
xy720 merged 9 commits into
apache:masterfrom
amorynan:feature-supportMapStreamLoad

Conversation

@amorynan

@amorynanamorynan commented Feb 15, 2023•
edited by xy720
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  1. support stream load with json, csv format for map
  2. fix olap convertor when compaction action in map column which has null
  3. support select outToFile for map
  4. add some regression-test

#16547

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Feb 15, 2023
@github-actions

github-actionsBot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 reviewed Feb 15, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some regression test

Comment threadbe/src/vec/data_types/data_type_map.cpp Outdated
Comment threadbe/src/vec/data_types/data_type_factory.cpp Outdated
xy720
xy720 reviewed Feb 15, 2023
View reviewed changes
Comment threadbe/src/vec/data_types/data_type_map.cpp Outdated
@github-actions

github-actionsBot commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang reviewed Feb 16, 2023
View reviewed changes
Comment threadregression-test/suites/map_p0/test_map_load_and_function.groovy Outdated
Comment threadbe/src/vec/olap/olap_data_convertor.cpp Outdated
Comment threadbe/src/vec/exprs/vexpr.cpp
xy720
xy720 previously approved these changes Feb 16, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 16, 2023
@github-actions

github-actionsBot commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xy720
xy720 reviewed Feb 16, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression test need to be changed.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Feb 16, 2023
@github-actions

github-actionsBot commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions

github-actionsBot commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot added area/nereids area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. labels Feb 17, 2023
github-actions[bot]
github-actionsBot reviewed Feb 17, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/test/olap/rowset/rowset_tree_test.cpp
Comment threadbe/test/olap/rowset/rowset_tree_test.cpp
@amorynan
amorynanforce-pushed the feature-supportMapStreamLoad branch from 979e5c1 to 9b8c433CompareFebruary 17, 2023 13:26
@github-actions

github-actionsBot commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang approved these changes Feb 18, 2023
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amorynan
amorynan requested a review from xy720February 18, 2023 08:19
xy720
xy720 approved these changes Feb 19, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2023
@github-actions

github-actionsBot commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xy720
xy720 merged commit 8b70bfd into apache:masterFeb 19, 2023
@amorynan
amorynan deleted the feature-supportMapStreamLoad branch February 20, 2023 02:47
@xy720xy720 mentioned this pull request Feb 24, 2023
Closed
88 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@amorynan@yagagagaga
[Feature](map-type) Support stream load and fix some bugs for map type (
5240275
apache#16776)
1、support stream load with json, csv format for map
2、fix olap convertor when compaction action in map column which has null
3、support select outToFile for map
4、add some regression-test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@xiaokangxiaokangxiaokang approved these changes
@xy720xy720xy720 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/nereidsarea/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorizationkind/docsCategorizes issue or PR as related to documentation.kind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amorynan@xiaokang@xy720