Skip to content

[Improve](map-type) Add contains_null for map - #16948

Merged
xy720 merged 6 commits into
apache:masterfrom
amorynan:improve-map
Feb 23, 2023
Merged

[Improve](map-type) Add contains_null for map #16948
xy720 merged 6 commits into
apache:masterfrom
amorynan:improve-map

Conversation

@amorynan

@amorynanamorynan commented Feb 20, 2023•
edited by xy720
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

add contains_null for map

#16547

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/vectorization labels Feb 20, 2023
@github-actions

github-actionsBot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 reviewed Feb 20, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java Outdated
@github-actionsgithub-actionsBot added the area/sql/function Issues or PRs related to the SQL functions label Feb 21, 2023
@github-actions

github-actionsBot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 reviewed Feb 21, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java Outdated
@github-actions

github-actionsBot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 previously approved these changes Feb 21, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2023
@github-actions

github-actionsBot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@amorynan

amorynan commented Feb 21, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Feb 22, 2023
@github-actions

github-actionsBot commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan

amorynan commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@amorynan

amorynan commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

run compile

@amorynan

amorynan commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@amorynan

amorynan commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan

amorynan commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@amorynan

amorynan commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xy720xy720 added the map-type Issues or PRs related to map type label Feb 23, 2023
@amorynan

amorynan commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run compile

xy720
xy720 approved these changes Feb 23, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720
xy720 merged commit 7229751 into apache:masterFeb 23, 2023
@xy720xy720 mentioned this pull request Feb 24, 2023
Closed
88 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
amory@yagagagaga
[Improve](map-type) Add contains_null for map (apache#16948)
b2655ab
Add contains_null for map type.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720xy720xy720 approved these changes

Assignees

No one assigned

Labels

area/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorizationmap-typeIssues or PRs related to map typereviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amorynan@xy720