Skip to content

[fix](struct-type) fix struct subtype support - #17081

Merged
xy720 merged 2 commits into
apache:masterfrom
cambyzju:fix-0223
Feb 28, 2023
Merged

[fix](struct-type) fix struct subtype support#17081
xy720 merged 2 commits into
apache:masterfrom
cambyzju:fix-0223

Conversation

@cambyzju

@cambyzjucambyzju commented Feb 23, 2023•
edited by xy720
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#16547

Problem summary

  1. Make sure all sub types which STRUCT supported work correctly;
  2. remove unused variable _need_validate_data;
  3. lazy init min or max decimal to support nested DecimalV2 column validate;

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/planner Issues or PRs related to the query planner area/vectorization kind/test labels Feb 23, 2023
@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Feb 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.34 seconds
stream load tsv: 489 seconds loaded 74807831229 Bytes, about 145 MB/s
stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s
stream load orc: 80 seconds loaded 1101869774 Bytes, about 13 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230227145450_clickbench_pr_105188.html

@cambyzju

cambyzju commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run feut

xy720
xy720 previously approved these changes Feb 23, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720

xy720 commented Feb 23, 2023

Copy link
Copy Markdown
Member

run p0

@xy720

xy720 commented Feb 23, 2023

Copy link
Copy Markdown
Member

run feut

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 23, 2023
@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Feb 24, 2023
@cambyzju

cambyzju commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run feut

@cambyzju

cambyzju commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@xy720xy720 mentioned this pull request Feb 24, 2023
Closed
88 tasks
@cambyzju

cambyzju commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Feb 26, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju

cambyzju commented Feb 26, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@cambyzju

cambyzju commented Feb 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@cambyzju

cambyzju commented Feb 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 approved these changes Feb 28, 2023
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2023
@github-actions

github-actionsBot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xy720
xy720 merged commit 4d8b310 into apache:masterFeb 28, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@cambyzjucambyzju@yagagagaga
[fix](struct-type) fix struct subtype support (apache#17081)
35440f5
1. Make sure all sub types which STRUCT supported work correctly;
2. remove unused variable `_need_validate_data`;
3. lazy init min or max decimal to support nested DecimalV2 column validate;
Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720xy720xy720 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerarea/vectorizationkind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Roadmap] Support Struct+Map Type

3 participants

@cambyzju@hello-stephen@xy720