Uh oh!
There was an error while loading. Please reload this page.
Make bitmap_union agg column support insert into and broker load - #1721
Conversation
imay
commented
Aug 29, 2019
@kangkaisen |
Uh oh!
There was an error while loading. Please reload this page.
kangkaisen
commented
Aug 29, 2019
|
| } | ||
| } else if (expr instanceof FunctionCallExpr) { | ||
| final FunctionCallExpr functionExpr = (FunctionCallExpr) expr; | ||
| if (!functionExpr.getFnName().getFunction().equalsIgnoreCase(FunctionSet.TO_BITMAP)) { |
There was a problem hiding this comment.
I think BITMAP_UNION() is OK too.
And you should add in
fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java:452
fe/src/main/java/org/apache/doris/planner/StreamLoadScanNode.java:278
| protected final TupleDescriptor desc; | ||
| protected Map<String, PartitionColumnFilter> columnFilters; | ||
| protected String sortColumn = null; | ||
| protected Map<String, SlotDescriptor> slotDescByName = Maps.newHashMap(); |
There was a problem hiding this comment.
If you want to unify BrokerScanNode and StreamScanNode, I think you'd better to make another class which is subclass of ScanNode. Because not all ScanNode has these properties, they only are used in loading.
morningman
commented
Aug 29, 2019
There are a lot change related to load process in my pull request #1695 . |
ca402cc to
8ac58efComparekangkaisen
commented
Aug 30, 2019
OK. I has minimized the change. |
For #1610, make bitmap_union support insert into select and broker load
1 Add a check for select * with bitmap_union
2 Define the bitmap_union column type to varchar(0), because the bitmap real length is variable, when insert into, the bitmap real length maybe larger than origin varchar length.
Test the following case:
1
2
3