Skip to content

[fix](segcompaction) heap overflow when doing segcompaction for cance… - #17529

Merged
zhannngchen merged 1 commit into
apache:masterfrom
freemandealer:fix-segcompaction-write-page-core
Mar 10, 2023
Merged

[fix](segcompaction) heap overflow when doing segcompaction for cance…#17529
zhannngchen merged 1 commit into
apache:masterfrom
freemandealer:fix-segcompaction-write-page-core

Conversation

@freemandealer

@freemandealerfreemandealer commented Mar 7, 2023

Copy link
Copy Markdown
Member

…lling load(#16731)

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

github-actionsBot commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer

freemandealer commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.16 seconds
stream load tsv: 458 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230308052221_clickbench_pr_110566.html

@morningmanmorningman added usercase Important user case type label dev/1.2.3 labels Mar 8, 2023
@freemandealer
[fix](segcompaction) heap overflow when doing segcompaction for cance…
4d30414
…lling load(apache#16731)
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@freemandealer
freemandealerforce-pushed the fix-segcompaction-write-page-core branch from 5b28a8a to 4d30414CompareMarch 8, 2023 02:50
@github-actions

github-actionsBot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer

freemandealer commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@freemandealer

freemandealer commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

run clickbench

dataroaring
dataroaring approved these changes Mar 8, 2023
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 8, 2023
@github-actions

github-actionsBot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@freemandealer

freemandealer commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

run p0

zhannngchen
zhannngchen approved these changes Mar 10, 2023
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
zhannngchen merged commit 2739a44 into apache:masterMar 10, 2023
@yiguoleiyiguolei removed usercase Important user case type label dev/1.2.3 labels Apr 4, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@freemandealer@gnehil
[fix](segcompaction) heap overflow when doing segcompaction for cance…
8878f53
…lling load(apache#17529)
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.need-cherry-pickreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer@hello-stephen@zhannngchen@dataroaring@morningman@yiguolei