Skip to content

[enhancement](nereids)support topN opt in nereids - #17741

Merged
englefly merged 2 commits into
apache:masterfrom
englefly:topn-opt
Mar 27, 2023
Merged

[enhancement](nereids)support topN opt in nereids#17741
englefly merged 2 commits into
apache:masterfrom
englefly:topn-opt

Conversation

@englefly

@engleflyenglefly commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

topN opt is implemented in original planner(refer to #15558)

This pr make nereids support this feature.

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly

englefly commented Mar 13, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.89 seconds
stream load tsv: 476 seconds loaded 74807831229 Bytes, about 149 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 76 seconds loaded 1101869774 Bytes, about 13 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230323135709_clickbench_pr_119679.html

@englefly

englefly commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly

englefly commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly

englefly commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@englefly

englefly commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly

englefly commented Mar 19, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly

englefly commented Mar 21, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly
engleflyforce-pushed the topn-opt branch 2 times, most recently from 610764e to 055e0f4CompareMarch 22, 2023 07:25
@englefly

englefly commented Mar 22, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@englefly
englefly requested a review from morrySnowMarch 23, 2023 01:06
@englefly

englefly commented Mar 23, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2023
@github-actions

github-actionsBot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@englefly
englefly merged commit c8e4684 into apache:masterMar 27, 2023
@englefly
englefly deleted the topn-opt branch March 27, 2023 10:58
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@englefly@gnehil
[enhancement](nereids)support topN opt in nereids (apache#17741)
06c23cc
1. support topN opt in nereids
2. pushdown limit->proj->sort
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
@morrySnowmorrySnowAwaiting requested review from morrySnowmorrySnow is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/nereidsreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@englefly@hello-stephen@starocean999