[fix](planner)fix failed to create view when use window function by sohardforaname · Pull Request #17815 · apache/doris

sohardforaname · 2023-03-15T06:59:00Z

Proposed changes

Issue Number: close #xxx

Problem summary

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

sohardforaname · 2023-03-15T07:03:37Z

run buildall

sohardforaname · 2023-03-15T09:27:51Z

run buildall

hello-stephen · 2023-03-15T09:30:43Z

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.94 seconds
stream load tsv: 467 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 26 seconds loaded 2358488459 Bytes, about 86 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230323051119_clickbench_pr_119300.html

sohardforaname · 2023-03-15T13:29:23Z

run buildall

sohardforaname · 2023-03-15T14:23:47Z

run fe ut

sohardforaname · 2023-03-15T14:23:59Z

run fe ut

sohardforaname · 2023-03-15T14:28:03Z

run buildall

sohardforaname · 2023-03-16T04:51:49Z

run buildall

sohardforaname · 2023-03-16T11:30:33Z

run fe ut

sohardforaname · 2023-03-16T11:43:11Z

run buildall

sohardforaname · 2023-03-17T06:32:31Z

run p0

sohardforaname · 2023-03-17T08:19:15Z

run buildall

sohardforaname · 2023-03-17T09:40:49Z

run p0

sohardforaname · 2023-03-21T02:54:43Z

run buildall

sohardforaname · 2023-03-21T05:18:09Z

run buildall

sohardforaname · 2023-03-21T07:28:29Z

run fe ut

sohardforaname · 2023-03-21T07:40:56Z

run fe ut

sohardforaname · 2023-03-21T09:00:40Z

run fe ut

sohardforaname · 2023-03-22T02:46:06Z

run buildall

sohardforaname · 2023-03-22T04:07:56Z

run buildall

sohardforaname · 2023-03-23T02:59:12Z

run p0

sohardforaname · 2023-03-23T03:01:22Z

run buildall

sohardforaname · 2023-03-23T11:09:18Z

run p0

github-actions · 2023-03-24T02:44:15Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-03-24T02:44:18Z

PR approved by anyone and no changes requested.

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

…pache#17815)" (apache#1591) fix failed to create view when use window function because the view string contains slot id and which cannot be parsed. Co-authored-by: mch_ucchi <41606806+sohardforaname@users.noreply.github.com>

…#17815) fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

…pache#17815)" (apache#1592) fix failed to create view when use window function because the view string contains slot id and which cannot be parsed. Co-authored-by: mch_ucchi <41606806+sohardforaname@users.noreply.github.com>

github-actionsBot added the area/planner Issues or PRs related to the query planner label Mar 15, 2023

github-actionsBot added the kind/test label Mar 15, 2023

morrySnow added dev/1.1.6 dev/1.2.3 usercase Important user case type label labels Mar 15, 2023

sohardforaname force-pushed the cir1792 branch from 2f15d00 to 6276724Compare March 16, 2023 04:51

sohardforaname force-pushed the cir1792 branch from 6276724 to 624b7c3Compare March 16, 2023 11:41

sohardforaname force-pushed the cir1792 branch from 624b7c3 to 18c4717Compare March 21, 2023 02:53

sohardforaname force-pushed the cir1792 branch from 18c4717 to dfded00Compare March 21, 2023 05:17

sohardforaname force-pushed the cir1792 branch from dfded00 to bb3d4ebCompare March 22, 2023 02:42

sohardforaname added 6 commits March 23, 2023 11:00

'fix-bugs'
3258d55

'fix-bugs'
ad5bd64

'fix-bugs'
84352a8

'fix-bugs'
0dae8af

'fix-bugs'
6b2be31

'fix-bugs'
c129f3f

sohardforaname force-pushed the cir1792 branch from ee2e681 to c129f3fCompare March 23, 2023 03:01

morrySnow approved these changes Mar 24, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2023

github-actionsBot added the reviewed label Mar 24, 2023

morrySnow merged commit aa3ea4b into apache:masterMar 24, 2023

morrySnow added dev/1.2.4 and removed dev/1.2.3 labels Mar 24, 2023

morningman added dev/1.2.4-merged and removed dev/1.2.4 labels Mar 28, 2023

morningman pushed a commit that referenced this pull request Mar 28, 2023
[fix](planner) failed to create view when use window function (#17815)
9cc3468
fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Uh oh!

Conversation

sohardforaname commented Mar 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Problem summary

Checklist(Required)

Further comments

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

hello-stephen commented Mar 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

sohardforaname commented Mar 15, 2023

Uh oh!

sohardforaname commented Mar 16, 2023

Uh oh!

sohardforaname commented Mar 16, 2023

Uh oh!

sohardforaname commented Mar 16, 2023

Uh oh!

sohardforaname commented Mar 17, 2023

Uh oh!

sohardforaname commented Mar 17, 2023

Uh oh!

sohardforaname commented Mar 17, 2023

Uh oh!

sohardforaname commented Mar 21, 2023

Uh oh!

sohardforaname commented Mar 21, 2023

Uh oh!

sohardforaname commented Mar 21, 2023

Uh oh!

sohardforaname commented Mar 21, 2023

Uh oh!

sohardforaname commented Mar 21, 2023

Uh oh!

sohardforaname commented Mar 22, 2023

Uh oh!

sohardforaname commented Mar 22, 2023

Uh oh!

sohardforaname commented Mar 23, 2023

Uh oh!

sohardforaname commented Mar 23, 2023

Uh oh!

sohardforaname commented Mar 23, 2023

Uh oh!

github-actionsBot commented Mar 24, 2023

Uh oh!

github-actionsBot commented Mar 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sohardforaname commented Mar 15, 2023•
edited
Loading

hello-stephen commented Mar 15, 2023•
edited
Loading