Skip to content

[revert](function) fix AES/SM3/SM4 encrypt/ decrypt algorithm initialization vector bug - #17887

Merged
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20230317_revert_fix_aes
Mar 22, 2023
Merged

[revert](function) fix AES/SM3/SM4 encrypt/ decrypt algorithm initialization vector bug#17887
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20230317_revert_fix_aes

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

This reverts commit 397cc01.

Proposed changes

Issue Number: close #xxx

Problem summary

revert #17420
There are compatibility issues, I will resubmit the pr later

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/nereids area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. kind/test labels Mar 17, 2023
@github-actions

github-actionsBot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Mar 17, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzz
xinyiZzzforce-pushed the 20230317_revert_fix_aes branch from b89ecd3 to 92db404CompareMarch 17, 2023 17:41
@github-actions

github-actionsBot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.06 seconds
stream load tsv: 456 seconds loaded 74807831229 Bytes, about 156 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 76 seconds loaded 1101869774 Bytes, about 13 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230321160512_clickbench_pr_118073.html

@xinyiZzz
xinyiZzzforce-pushed the 20230317_revert_fix_aes branch from 92db404 to 5ee79f2CompareMarch 18, 2023 18:54
@xinyiZzz

xinyiZzz commented Mar 18, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz

xinyiZzz commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run p0

@xinyiZzz
xinyiZzzforce-pushed the 20230317_revert_fix_aes branch from 5ee79f2 to 26589b1CompareMarch 20, 2023 03:08
@xinyiZzz

xinyiZzz commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
xinyiZzzforce-pushed the 20230317_revert_fix_aes branch from 26589b1 to 5e2d48fCompareMarch 20, 2023 13:06
@xinyiZzz

xinyiZzz commented Mar 20, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
xinyiZzzforce-pushed the 20230317_revert_fix_aes branch from 5e2d48f to 5627ff3CompareMarch 21, 2023 06:38
@xinyiZzz

xinyiZzz commented Mar 21, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Mar 22, 2023
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit ebef0c0 into apache:masterMar 22, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@xinyiZzz@gnehil
Revert "[fix](function) fix AES/SM3/SM4 encrypt/ decrypt algorithm in…
ced0666
…itialization vector bug (apache#17420)" (apache#17887)
This reverts commit 397cc01.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

area/nereidsarea/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorizationkind/docsCategorizes issue or PR as related to documentation.kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinyiZzz@hello-stephen@yiguolei