[fix](like) fix wrong result of like pattern with backslash by jacktengg · Pull Request #18039 · apache/doris

jacktengg · 2023-03-22T17:01:28Z

Proposed changes

Issue Number: close #xxx

Problem summary

Result is empty for query select * from person where address like '%\\\\%';, but MySQL can get a line of result.

CREATE TABLE `person` (
`id` int(11) NULL,
`name` text NULL,
`age` int(11) NULL,
`class` int(11) NULL,
`address` text NULL
) ENGINE=OLAP
UNIQUE KEY(`id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`id`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2",
"disable_auto_compaction" = "false"
); insert into person values (10001,'test1',30,2,'test\\\\,xxx');

Adding logs:

select * from person where address like '%\\\\%';
I0323 10:26:15.907760 2387043 like.cpp:558] arg str: %\\%, size: 4, pattern LIKE_ENDS_WITH_RE: (?:%+)(((\\%)|(\\_)|([^%_]))+), size: 30
I0323 10:26:15.907789 2387043 like.cpp:562] match 0: \\%, size: 3
I0323 10:26:15.907801 2387043 like.cpp:562] match 1: \%, size: 2
I0323 10:26:15.907811 2387043 like.cpp:562] match 2: \%, size: 2
I0323 10:26:15.907821 2387043 like.cpp:562] match 3: , size: 0
I0323 10:26:15.907830 2387043 like.cpp:562] match 4: \, size: 1
I0323 10:26:15.907842 2387043 like.cpp:615] search_string : \\%
I0323 10:26:15.907855 2387043 like.cpp:619] search_string escape removed: \%

It matchs against the LIKE_ENDS_WITH_RE which is wrong, the meaning of the sql should be: match strings that have one backslash in any place.

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

jacktengg · 2023-03-22T17:03:59Z

run buildall

github-actions · 2023-03-22T17:04:22Z

clang-tidy review says "All clean, LGTM! 👍"

hello-stephen · 2023-03-23T02:45:49Z

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.55 seconds
stream load tsv: 447 seconds loaded 74807831229 Bytes, about 159 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230329080505_clickbench_pr_122211.html

github-actions · 2023-03-23T09:46:32Z

clang-tidy review says "All clean, LGTM! 👍"

xiaokang

LGTM

github-actions · 2023-03-23T13:42:51Z

PR approved by anyone and no changes requested.

github-actions · 2023-03-24T06:19:36Z

clang-tidy review says "All clean, LGTM! 👍"

jacktengg · 2023-03-24T08:10:31Z

run buildall

yiguolei

LGTM

github-actions · 2023-03-24T10:13:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-03-27T02:52:06Z

clang-tidy review says "All clean, LGTM! 👍"

jacktengg · 2023-03-27T03:11:43Z

run buildall

jacktengg · 2023-03-28T01:45:02Z

run buildall

github-actions · 2023-03-28T01:48:08Z

clang-tidy review says "All clean, LGTM! 👍"

jacktengg · 2023-03-29T07:41:58Z

run buildall

github-actions · 2023-03-29T07:45:13Z

clang-tidy review says "All clean, LGTM! 👍"

yiguolei

LGTM

…8039) Result is empty for query select * from person where address like '%\\\\%';, but MySQL can get a line of result. CREATE TABLE `person` ( `id` int(11) NULL, `name` text NULL, `age` int(11) NULL, `class` int(11) NULL, `address` text NULL ) ENGINE=OLAP UNIQUE KEY(`id`) COMMENT 'OLAP' DISTRIBUTED BY HASH(`id`) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "in_memory" = "false", "storage_format" = "V2", "disable_auto_compaction" = "false" ); insert into person values (10001,'test1',30,2,'test\\\\,xxx'); Adding logs: select * from person where address like '%\\\\%'; I0323 10:26:15.907760 2387043 like.cpp:558] arg str: %\\%, size: 4, pattern LIKE_ENDS_WITH_RE: (?:%+)(((\\%)|(\\_)|([^%_]))+), size: 30 I0323 10:26:15.907789 2387043 like.cpp:562] match 0: \\%, size: 3 I0323 10:26:15.907801 2387043 like.cpp:562] match 1: \%, size: 2 I0323 10:26:15.907811 2387043 like.cpp:562] match 2: \%, size: 2 I0323 10:26:15.907821 2387043 like.cpp:562] match 3: , size: 0 I0323 10:26:15.907830 2387043 like.cpp:562] match 4: \, size: 1 I0323 10:26:15.907842 2387043 like.cpp:615] search_string : \\% I0323 10:26:15.907855 2387043 like.cpp:619] search_string escape removed: \% It matchs against the LIKE_ENDS_WITH_RE which is wrong, the meaning of the sql should be: match strings that have one backslash in any place.

github-actionsBot added area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test labels Mar 22, 2023

morningman added the dev/1.2.3 label Mar 23, 2023

yiguolei added dev/1.2.4 usercase Important user case type label and removed dev/1.2.3 labels Mar 23, 2023

jacktengg force-pushed the fix-like branch from 8347f03 to ec8c152Compare March 23, 2023 09:42

xiaokang previously approved these changes Mar 23, 2023
View reviewed changes

github-actionsBot added the reviewed label Mar 23, 2023

jacktengg dismissed xiaokang’s stale review via 5998d42March 24, 2023 06:15

jacktengg force-pushed the fix-like branch from ec8c152 to 5998d42Compare March 24, 2023 06:15

yiguolei previously approved these changes Mar 24, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2023

jacktengg dismissed yiguolei’s stale review via bb63ef1March 27, 2023 02:48

jacktengg force-pushed the fix-like branch from 5998d42 to bb63ef1Compare March 27, 2023 02:48

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Mar 27, 2023

jacktengg force-pushed the fix-like branch from bb63ef1 to 29a5d07Compare March 28, 2023 01:44

jacktengg added 2 commits March 29, 2023 15:41

[fix](like) fix wrong result of like pattern with backslash
1ce2d74

fix and add test cases
1c07011

jacktengg force-pushed the fix-like branch from 29a5d07 to 1c07011Compare March 29, 2023 07:41

yiguolei approved these changes Mar 30, 2023
View reviewed changes

yiguolei merged commit 9877143 into apache:masterMar 30, 2023

jacktengg mentioned this pull request Apr 3, 2023
[fix](like) fix wrong result of like pattern with backslash #18351
Merged
5 tasks

morningman added the need-cherry-pick label Apr 3, 2023

yiguolei added dev/1.2.4-merged and removed dev/1.2.4 labels Apr 3, 2023

zclllyybb mentioned this pull request Jan 30, 2024
[fix](regex) fix wrong escape of function LIKE #30557
Merged

Uh oh!

Conversation

jacktengg commented Mar 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Problem summary

Checklist(Required)

Further comments

Uh oh!

jacktengg commented Mar 22, 2023

Uh oh!

github-actionsBot commented Mar 22, 2023

Uh oh!

hello-stephen commented Mar 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Mar 23, 2023

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Mar 23, 2023

Uh oh!

github-actionsBot commented Mar 24, 2023

Uh oh!

jacktengg commented Mar 24, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Mar 24, 2023

Uh oh!

github-actionsBot commented Mar 27, 2023

Uh oh!

jacktengg commented Mar 27, 2023

Uh oh!

jacktengg commented Mar 28, 2023

Uh oh!

github-actionsBot commented Mar 28, 2023

Uh oh!

jacktengg commented Mar 29, 2023

Uh oh!

github-actionsBot commented Mar 29, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jacktengg commented Mar 22, 2023•
edited
Loading

hello-stephen commented Mar 23, 2023•
edited
Loading