Skip to content

[fix](multi-catalog) key and value columns of map are normal column type - #18160

Merged
morningman merged 1 commit into
apache:masterfrom
AshinGau:fix_map
Mar 28, 2023
Merged

[fix](multi-catalog) key and value columns of map are normal column type#18160
morningman merged 1 commit into
apache:masterfrom
AshinGau:fix_map

Conversation

@AshinGau

Copy link
Copy Markdown
Member

Proposed changes

Problem summary

PR(#17330) has changed the column type of kay and value from array to normal column, but orc&parquet reader still cast to array column, resulting in cast error.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen

Copy link
Copy Markdown
Contributor

LGTM

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 28, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit a813ad5 into apache:masterMar 28, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…ype (apache#18160)
PR(apache#17330) has changed the column type of kay and value from array to normal column, but orc&parquet reader still cast to array column, resulting in cast error.
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…ype (apache#18160)
PR(apache#17330) has changed the column type of kay and value from array to normal column, but orc&parquet reader still cast to array column, resulting in cast error.
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
…ype (apache#18160)
PR(apache#17330) has changed the column type of kay and value from array to normal column, but orc&parquet reader still cast to array column, resulting in cast error.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…ype (apache#18160)
PR(apache#17330) has changed the column type of kay and value from array to normal column, but orc&parquet reader still cast to array column, resulting in cast error.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/vectorizationreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AshinGau@kaka11chen@morningman