Skip to content

[feature](struct-type) support basic struct constructor function - #18190

Merged
xy720 merged 12 commits into
apache:masterfrom
xy720:support-struct-functions
Apr 13, 2023
Merged

[feature](struct-type) support basic struct constructor function#18190
xy720 merged 12 commits into
apache:masterfrom
xy720:support-struct-functions

Conversation

@xy720

@xy720xy720 commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

ref #16547

This commit will support struct constructor function.

need to merge #18392 first.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Mar 28, 2023
@github-actions

github-actionsBot commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actionsBot reviewed Mar 30, 2023
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/functions/function_struct.cpp Outdated
Comment threadbe/src/vec/functions/function_struct.cpp Outdated
@xy720
xy720force-pushed the support-struct-functions branch from 0995218 to f4d61dbCompareApril 4, 2023 17:58
@github-actions

github-actionsBot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot added the area/planner Issues or PRs related to the query planner label Apr 4, 2023
@github-actions

github-actionsBot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720

xy720 commented Apr 6, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

cambyzju
cambyzju previously approved these changes Apr 6, 2023
View reviewed changes

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 6, 2023
@github-actions

github-actionsBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@xy720
xy720force-pushed the support-struct-functions branch from 7d6c487 to 330ce8eCompareApril 11, 2023 11:51
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 11, 2023
@github-actions

github-actionsBot commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720
xy720force-pushed the support-struct-functions branch from 330ce8e to 65336c5CompareApril 11, 2023 12:02
@xy720

xy720 commented Apr 11, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720

xy720 commented Apr 12, 2023

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

cambyzju
cambyzju approved these changes Apr 12, 2023
View reviewed changes

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 12, 2023
@github-actions

github-actionsBot commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xy720
xy720 merged commit d57371d into apache:masterApr 13, 2023
@xy720xy720 mentioned this pull request Apr 13, 2023
Closed
88 tasks
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@xy720@gnehil
[feature](struct-type) support basic struct constructor function (apa…
535192e
…che#18190)
This commit will support struct and named_struct function.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
@xy720@Reminiscent
[feature](struct-type) support basic struct constructor function (apa…
4b73199
…che#18190)
This commit will support struct and named_struct function.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@cambyzjucambyzjucambyzju approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerarea/sql/functionIssues or PRs related to the SQL functionsarea/vectorizationkind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xy720@cambyzju