Skip to content

Seek block when starts a ScanKey - #1828

Merged
chaoyli merged 4 commits into
apache:masterfrom
chaoyli:master
Sep 19, 2019
Merged

Seek block when starts a ScanKey#1828
chaoyli merged 4 commits into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

@chaoylichaoyli commented Sep 19, 2019

Copy link
Copy Markdown
Contributor

In Doris, one block has 1024 rows.

  1. If the previous ScanKey scan rows multiple blocks,
    and also the final block has 1024 rows just right.
  2. The current ScanKey scan rows with number less than one block.
    Under the two conditions, if not seek block, the position of prefix shortkey columns is wrong.

chaoyli added 2 commits September 19, 2019 12:53
chaoyli
Check file descriptor number is larger than 65536 upon start
61cbffe
chaoyli
Seek block when starts a ScanKey.
0f59e22
In Doris, one block has 1024 rows.
1. If the previous ScanKey scan rows multiple blocks,
and also the final block has 1024 rows just right.
2. The current ScanKey scan rows with number less than one block.
Under the two conditions, if not seek block, the position of prefix shortkey columns is wrong.
imay
imay reviewed Sep 19, 2019
View reviewed changes
Comment threadbe/src/olap/rowset/segment_reader.h Outdated
morningman
morningman reviewed Sep 19, 2019
View reviewed changes
Comment threadbe/src/olap/rowset/segment_reader.h Outdated
Comment threadbe/src/olap/rowset/segment_reader.cpp Outdated
morningman
morningman approved these changes Sep 19, 2019
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imay
imay approved these changes Sep 19, 2019
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaoylichaoyli closed this Sep 19, 2019
@chaoylichaoyli reopened this Sep 19, 2019
@chaoyli
chaoyli merged commit 315f762 into apache:masterSep 19, 2019
chaoyli pushed a commit to baidu-doris/incubator-doris that referenced this pull request Sep 19, 2019
lichaoyong
Merge pull request#3from chaoyli/branch-0.10
d9bfc4d
Seek block when starts a ScanKey (apache#1828)
@imayimay mentioned this pull request Sep 26, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imayimayimay approved these changes
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaoyli@imay@morningman