Skip to content

[cherry-pick-1.2][fix](expr) refractor create_tree_from_thrift to avoid stack overflow - #18597

Merged
yangzhg merged 1 commit into
apache:branch-1.2-ltsfrom
cambyzju:cherry-pick-18514
Apr 13, 2023
Merged

[cherry-pick-1.2][fix](expr) refractor create_tree_from_thrift to avoid stack overflow#18597
yangzhg merged 1 commit into
apache:branch-1.2-ltsfrom
cambyzju:cherry-pick-18514

Conversation

@cambyzju

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#18036

Problem summary

cherry-pick #18514 to 1.2-lts.

refractor create_tree_from_thrift to avoid stack overflow for vec and non-vec engine.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…d stack overflow (apache#18514)
* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine
* update
@cambyzjucambyzju changed the title [cherry-pick-1.2](fix-expr) refractor create_tree_from_thrift to avoid stack overflow[cherry-pick-1.2][fix](expr) refractor create_tree_from_thrift to avoid stack overflowApr 12, 2023
@cambyzju

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yangzhg
yangzhg merged commit 1a4a235 into apache:branch-1.2-ltsApr 13, 2023
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…d stack overflow (apache#18514) (apache#18597)
* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/vectorizationreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cambyzju@yangzhg