Skip to content

collect scanner's status when es_http_scan_node close - #1861

Merged
imay merged 4 commits into
apache:masterfrom
shgxwxl:fix-1859
Sep 25, 2019
Merged

collect scanner's status when es_http_scan_node close#1861
imay merged 4 commits into
apache:masterfrom
shgxwxl:fix-1859

Conversation

@shgxwxl

Copy link
Copy Markdown
Contributor

add collect_scanners_status function ,which need to call after start_scanners to check status

@shgxwxlshgxwxl closed this Sep 24, 2019
@shgxwxlshgxwxl reopened this Sep 24, 2019
Comment threadbe/src/exec/es_http_scan_node.cpp Outdated
Comment threadbe/src/exec/es_http_scan_node.cpp Outdated
@shgxwxlshgxwxl changed the title fix #1859 ut okcollect scanners status when es_http_scan_node closeSep 24, 2019
@shgxwxlshgxwxl changed the title collect scanners status when es_http_scan_node closecollect scanner's status when es_http_scan_node closeSep 24, 2019
@shgxwxl

shgxwxl commented Sep 24, 2019

Copy link
Copy Markdown
ContributorAuthor

fix #1859
collect all scanners status when es_http_scan_node close
make function collect_scanners_status from public to private
change ut for es_http_scan_node and run ok

Comment threadbe/src/exec/es_http_scan_node.cpp Outdated
call collect_scanners_status before ExecNode::close(state)

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay
imay merged commit c2de62d into apache:masterSep 25, 2019
@imayimay mentioned this pull request Sep 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shgxwxl@imay