Skip to content

[Fix](mutli-catalog) Fix decimal v3 precision loss issues in the multi-catalog module. - #18835

Merged
morningman merged 1 commit into
apache:masterfrom
kaka11chen:multi_catalog_decimalV3
Apr 20, 2023
Merged

[Fix](mutli-catalog) Fix decimal v3 precision loss issues in the multi-catalog module.#18835
morningman merged 1 commit into
apache:masterfrom
kaka11chen:multi_catalog_decimalV3

Conversation

@kaka11chen

@kaka11chenkaka11chen commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Problem summary

Issue Number: close#18833

Proposed changes

Fix decimal v3 precision loss issues in the multi-catalog module.
Now it will use decimal v3 to represent decimal type in the multi-catalog module.
Regression Test: test_load_with_decimal.groovy

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.42 seconds
stream load tsv: 433 seconds loaded 74807831229 Bytes, about 164 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230419175228_clickbench_pr_131293.html

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit 3328a65 into apache:masterApr 20, 2023
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Apr 20, 2023
… multi-catalog module. (apache#18835)
Fix decimal v3 precision loss issues in the multi-catalog module.
Now it will use decimal v3 to represent decimal type in the multi-catalog module.
Regression Test: `test_load_with_decimal.groovy`
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Apr 20, 2023
… multi-catalog module. (apache#18835)
Fix decimal v3 precision loss issues in the multi-catalog module.
Now it will use decimal v3 to represent decimal type in the multi-catalog module.
Regression Test: `test_load_with_decimal.groovy`
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
… multi-catalog module. (apache#18835)
Fix decimal v3 precision loss issues in the multi-catalog module.
Now it will use decimal v3 to represent decimal type in the multi-catalog module.
Regression Test: `test_load_with_decimal.groovy`
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
… multi-catalog module. (apache#18835)
Fix decimal v3 precision loss issues in the multi-catalog module.
Now it will use decimal v3 to represent decimal type in the multi-catalog module.
Regression Test: `test_load_with_decimal.groovy`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Decimal v3 precision loss in the multi catalog module.

3 participants

@kaka11chen@hello-stephen@morningman