[feature](merge-on-write) enable merge on write by default by zhannngchen · Pull Request #19017 · apache/doris

zhannngchen · 2023-04-24T13:56:20Z

Proposed changes

Issue Number: close #xxx

Problem summary

enable merge on write by default

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

zhannngchen · 2023-04-24T14:06:13Z

run buildall

hello-stephen · 2023-04-24T14:30:30Z

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.74 seconds
stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230506114735_clickbench_pr_139450.html

zhannngchen · 2023-04-24T14:43:13Z

run buildall

zhannngchen · 2023-04-24T16:30:09Z

run buildall

zhannngchen · 2023-04-25T02:45:17Z

run buildall

zhannngchen · 2023-04-25T08:25:25Z

egression-test/suites/schema_change_p0/test_uniq_mv_schema_change.groovy caused BE core when creating mv1, @BiteTheDDDDt will help to take a look.

dataroaring

LGTM

github-actions · 2023-04-30T12:23:51Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-04-30T12:23:53Z

PR approved by anyone and no changes requested.

zhannngchen · 2023-04-30T17:09:41Z

run buildall

zhannngchen · 2023-05-04T08:54:03Z

run buildall

zhannngchen · 2023-05-05T06:19:22Z

run buildall

zhannngchen · 2023-05-05T08:37:25Z

run buildall

zhannngchen · 2023-05-05T13:48:10Z

run buildall

zhannngchen · 2023-05-06T06:43:35Z

run buildall

zhannngchen · 2023-05-06T07:08:00Z

run buildall

zhannngchen · 2023-05-06T11:13:37Z

run buildall

dataroaring

LGTM

…pache#19017)" This reverts commit 5167dc1.

github-actionsBot added the area/planner Issues or PRs related to the query planner label Apr 24, 2023

github-actionsBot added the area/nereids label Apr 24, 2023

morningman added the dev/2.0.0-alpha1 should be merged into branch-2.0-alpha label Apr 25, 2023

zhannngchen force-pushed the enable_mow_by_default1 branch from 8124a82 to 0abf552Compare April 25, 2023 02:32

dataroaring previously approved these changes Apr 30, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 30, 2023

github-actionsBot added the reviewed label Apr 30, 2023

zhannngchen dismissed dataroaring’s stale review via c7dedfbApril 30, 2023 15:17

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 30, 2023

github-actionsBot added the kind/test label May 4, 2023

zhannngchen force-pushed the enable_mow_by_default1 branch from e416056 to 6418b01Compare May 5, 2023 01:48

zhannngchen force-pushed the enable_mow_by_default1 branch from 6418b01 to 61bd21bCompare May 5, 2023 08:30

zhannngchen force-pushed the enable_mow_by_default1 branch from 61bd21b to 22e4ce3Compare May 5, 2023 13:47

zhannngchen force-pushed the enable_mow_by_default1 branch from 22e4ce3 to 77745afCompare May 6, 2023 04:50

[feature](merge-on-write) enable merge on write by default
f30b261

zhannngchen added 9 commits May 6, 2023 19:10

update
abfc347

fix ut
f203594

fix ut
9a34c9b

fix create mv
1a7002b

fix
a0f22b4

fix regression p0
5c9af87

fix regression p0
c4aaa23

fix regression p0
6cbecfb

fix regression p0
05d673b

zhannngchen force-pushed the enable_mow_by_default1 branch from 5a4d763 to 05d673bCompare May 6, 2023 11:10

dataroaring approved these changes May 11, 2023
View reviewed changes

dataroaring merged commit 5167dc1 into apache:masterMay 11, 2023

zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jun 19, 2023
Revert "[feature](merge-on-write) enable merge on write by default (a…
f6de914
…pache#19017)" This reverts commit 5167dc1.

zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jun 20, 2023
Revert "[feature](merge-on-write) enable merge on write by default (a…
643e9eb
…pache#19017)" This reverts commit 5167dc1.

zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Jun 20, 2023
Revert "[feature](merge-on-write) enable merge on write by default (a…
3679be8
…pache#19017)" This reverts commit 5167dc1.

zhannngchen mentioned this pull request Nov 17, 2023
[feature](merge-on-write) enable merge-on-write by default #27188
Merged

Uh oh!

Conversation

zhannngchen commented Apr 24, 2023

Proposed changes

Problem summary

Checklist(Required)

Further comments

Uh oh!

zhannngchen commented Apr 24, 2023

Uh oh!

hello-stephen commented Apr 24, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhannngchen commented Apr 24, 2023

Uh oh!

zhannngchen commented Apr 24, 2023

Uh oh!

zhannngchen commented Apr 25, 2023

Uh oh!

zhannngchen commented Apr 25, 2023

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 30, 2023

Uh oh!

github-actionsBot commented Apr 30, 2023

Uh oh!

zhannngchen commented Apr 30, 2023

Uh oh!

zhannngchen commented May 4, 2023

Uh oh!

zhannngchen commented May 5, 2023

Uh oh!

zhannngchen commented May 5, 2023

Uh oh!

zhannngchen commented May 5, 2023

Uh oh!

zhannngchen commented May 6, 2023

Uh oh!

zhannngchen commented May 6, 2023

Uh oh!

zhannngchen commented May 6, 2023

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hello-stephen commented Apr 24, 2023•
edited
Loading