Uh oh!
There was an error while loading. Please reload this page.
[Enhancement](data-type) add FE config to prohibit create date and decimalv2 type - #19077
Merged
Conversation
Cai-Yao
commented
Apr 26, 2023
ContributorAuthor
run buildall |
Contributor
TeamCity pipeline, clickbench performance test result: |
yiguolei
commented
Apr 28, 2023
Contributor
run buildall |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
xiaokang pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 28, 2023
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
Mryange pushed a commit
to Mryange/doris
that referenced
this pull request
Apr 28, 2023
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
5 tasks
yiguolei pushed a commit
that referenced
this pull request
May 6, 2023
…19247) This PR enables periodic collection of statistics and is a precursor to automatic statistics collection. It mainly includes the following contents： support periodic collection of statistics. Change the type of Date in statistics p0 to DateV2(see [Enhancement](data-type) add FE config to prohibit create date and decimalv2 type #19077) for test locally. complement cases(remove Chinese characters, optimize code, etc) , improve stability. Supports setting whether to keep records of statistics synchronization job info, convenient for use in p0 testing. The statistics job table was modified, and some auxiliary judgments were added to avoid the user perceiving the modification. This function was removed when the table schema is stable.
Reminiscent pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
Reminiscent pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
…pache#19247) This PR enables periodic collection of statistics and is a precursor to automatic statistics collection. It mainly includes the following contents： support periodic collection of statistics. Change the type of Date in statistics p0 to DateV2(see [Enhancement](data-type) add FE config to prohibit create date and decimalv2 type apache#19077) for test locally. complement cases(remove Chinese characters, optimize code, etc) , improve stability. Supports setting whether to keep records of statistics synchronization job info, convenient for use in p0 testing. The statistics job table was modified, and some auxiliary judgments were added to avoid the user perceiving the modification. This function was removed when the table schema is stable.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
FE config
disable_decimalv2, default is true.disable_datev1, default is true.Afterwards, Doris prohibits creating tables containing the
DATEandDECIMALtype by default.Because of intending to delete these types in the future. At this stage, If you need to use these types, you need to add
disable_datev1 = falseordisable_decimalv2 = falsein the FE's config and restart the FE.On regression pipeline, these parameters in FE config is set false.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...