Skip to content

Segment v2 use string's real length(#1943) - #1944

Merged
imay merged 4 commits into
apache:masterfrom
wangbo:master
Oct 13, 2019
Merged

Segment v2 use string's real length(#1943)#1944
imay merged 4 commits into
apache:masterfrom
wangbo:master

Conversation

@wangbo

@wangbowangbo commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

imay
imay requested changes Oct 10, 2019
View reviewed changes
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/rowset/segment_v2/segment_writer.cpp Outdated
Comment threadbe/src/olap/rowset/segment_v2/segment_writer.cpp Outdated
Comment threadbe/src/olap/rowset/segment_v2/column_writer.cpp Outdated
@wangbowangbo closed this Oct 12, 2019
@wangbowangbo reopened this Oct 12, 2019
imay
imay reviewed Oct 12, 2019
View reviewed changes
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/field.h Outdated
Comment threadbe/src/olap/types.h
@wangbo
1. set type<char/varchar> set_to_max to nullptr
aba3b58
2. change allocate_memory comment
3. remove allocate_value_from_arena from type.h
imay
imay approved these changes Oct 12, 2019
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay
imay merged commit 80e9b21 into apache:masterOct 13, 2019
xy720 pushed a commit to xy720/doris that referenced this pull request Oct 18, 2019
@wangboxy720
Make Segment v2 use string's real length(apache#1943) (apache#1944)
aa5ea6e
wuyunfeng pushed a commit to wuyunfeng/incubator-doris that referenced this pull request Oct 22, 2019
@wangbo@wuyunfeng
Make Segment v2 use string's real length(apache#1943) (apache#1944)
a7b3e2b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imayimayimay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangbo@imay